Django Tutorial Walkthrough 5

This is part 5 of the Django tutorial walkthrough, covering writing tests. https://docs.djangoproject.com/en/4.0/intro/tutorial05/

Transcript

The following transcript was automatically generated by an algorithm.

00:01 : welcome to uh part five of the code
00:04 : tutorial walkthrough for the django web
00:06 : application framework
00:10 : here we are um
00:13 : so
00:14 : so last time we built a um
00:17 : some forms uh
00:19 : allowing us to be able to
00:22 : go to a question
00:26 : and vote on
00:28 : for example what's for dinner
00:30 : and then the votes are counted
00:33 : and if i keep voting the
00:37 : the tallies update correctly
00:40 : and the data is saved in the database
00:44 : uh
00:46 : a sqlite database to be more specific
00:49 : although
00:50 : you
00:51 : uh you can easily switch to a different
00:54 : uh database backend
00:57 : um
00:58 : let me close out this
01:00 : video application okay
01:02 : so
01:03 : this time what are we doing uh oh
01:06 : we're introducing automated testing okay
01:11 : uh so
01:12 : tests are routines that check the
01:14 : operation of your code
01:17 : um
01:18 : so we're gonna write
01:20 : some unit tests uh not necessary some
01:23 : might actually be
01:25 : higher level integration tests
01:27 : as well so so why are we creating tests
01:30 : um
01:32 : you may feel that you have quite enough
01:34 : on your plate just learning python and
01:35 : django and having yet another thing to
01:38 : learn and do may seem overwhelming
01:41 : yes i
01:42 : have definitely um
01:46 : i can definitely empathize with that
01:50 : as well
01:52 : when newcomers uh
01:54 : are trying to learn
01:56 : something and
01:58 : they are uh
02:00 : they're asked
02:02 : to learn a
02:03 : just a lot of things all at the same
02:06 : time
02:07 : but
02:08 : tests will save you time
02:10 : i'm gonna skip
02:12 : the explanation
02:15 : and i'm not going to try to convince you
02:18 : to write tests i don't necessarily write
02:21 : tests
02:22 : for
02:23 : necessarily everything i do myself
02:26 : i'm going to
02:28 : go right into the doing
02:31 : and then as we're going through the
02:33 : motion
02:34 : i will talk
02:36 : um
02:38 : i will add more edit editorializing
02:42 : at that time how about that um so last
02:45 : time we replaced some old code that i
02:48 : commented out i'm gonna delete those
02:53 : to sort of uh clean this up a little bit
02:58 : okay
02:59 : um
03:01 : we identify a bug
03:04 : oh that's nice
03:06 : we're going to identify a bug first
03:08 : before we write our tests interesting
03:12 : so question was published recently
03:15 : method returns true if the question was
03:19 : published within the last day
03:22 : which is correct but
03:24 : also if the questions update field
03:29 : is in the future which isn't
03:33 : let me
03:35 : check the code for that
03:37 : so oh they're saying this method
03:40 : um
03:44 : they're saying if the oh if it's in the
03:47 : future
03:49 : yeah that's true if it's in the future
03:53 : then it's still going to be greater than
03:57 : now
03:59 : minus
04:01 : some amount of time so they're saying we
04:03 : shouldn't allow that okay
04:05 : fair
04:06 : uh so we can use the shell
04:09 : to verify that uh let's follow suit and
04:12 : do that
04:16 : oh i just broke the code
04:19 : i need to put a dash here
04:21 : to go to the next line okay so
04:29 : i do appreciate the way this tutorial
04:32 : was put together uh
04:35 : i can tell it was done with a lot of
04:37 : thought
04:39 : um okay
04:41 : so
04:41 : [Music]
04:46 : so i'm gonna do
04:51 : i'll just copy this i don't feel like
04:54 : typing them all out now
05:00 : so a future question
05:04 : um
05:06 : 30 days into the future
05:11 : [Music]
05:13 : date
05:14 : so the pub date is
05:19 : march
05:20 : 4th i guess
05:22 : yeah
05:23 : so was this published recently
05:27 : and the answer will be true and that's
05:29 : the bug and we want to fix that okay so
05:32 : we're going to create a
05:34 : test to expose
05:36 : the bug and uh we're gonna want to
05:39 : create a tests.py file
05:43 : inside the polls directory oh it already
05:46 : exists okay
05:48 : um
05:50 : we want to do add these same imports
05:56 : i'm just going to copy them
05:58 : i'm not learning a lot by typing them
06:01 : out because i already am familiar with
06:03 : these
06:05 : um now i'm going to write a test a test
06:07 : is a class looks like
06:10 : that
06:13 : inherits from test case
06:16 : which is over here
06:18 : imported from django.test
06:22 : and we're going to
06:23 : define a
06:25 : test
06:26 : method
06:27 : called test
06:29 : was published
06:31 : recently
06:33 : with future
06:34 : question okay
06:37 : it's a very
06:38 : long and verbose
06:41 : method name
06:42 : i think that's fine and i'm going to
06:44 : create a time
06:48 : let's times on that now plus 30 days
06:53 : which is done with daytime dot time
06:56 : delta
06:58 : with days equals to
07:01 : so this time should be 30 days in the
07:04 : into the future
07:06 : so future question
07:09 : is going to be question
07:11 : with this
07:13 : update
07:16 : interesting they didn't even specify the
07:18 : question text
07:22 : i think that's fine i don't mind
07:25 : assert is okay
07:28 : a future question
07:31 : that was published
07:34 : recently
07:38 : false
07:42 : so we're saying we won't assert the fact
07:45 : that this was
07:47 : was published recently should return
07:49 : false
07:50 : and if it's that's not the case
07:53 : um
07:54 : we're going to get an error when running
07:56 : the test
07:58 : let's run the test
08:02 : just get out of the shell
08:08 : okay get out of the shell
08:12 : okay
08:14 : i think it's
08:15 : control
08:16 : d
08:17 : is what it is
08:19 : to get out of the shell also now i'll
08:21 : run the tests which is python manage the
08:24 : pi test
08:29 : and uh we have
08:31 : one error
08:33 : uh
08:35 : day is an invalid keyword for
08:38 : new
08:42 : that's not the error i was expecting so
08:45 : it needs to be days
08:48 : over here
08:51 : plural
08:52 : run the test again
08:56 : okay
08:56 : this time that's the error i was
08:58 : expecting so when we did an assertion
09:01 : here we asserted the value
09:04 : returned by this function to be false
09:07 : but it ended up being true and it's
09:10 : saying
09:11 : the test
09:12 : runner is telling me
09:14 : true is not false
09:18 : okay
09:21 : it would have been more useful if they
09:24 : told me
09:25 : future question was published recently
09:29 : is not false maybe although then you you
09:32 : wouldn't know what value it actually got
09:36 : it would have been helpful to be pointed
09:39 : to to this exact line of code
09:43 : and be able to tell
09:46 : what exactly was uh but i guess
09:49 : the reason i don't get it is because i
09:51 : did this
09:52 : i i wrote this in on a separate line
09:56 : okay
09:59 : that's kind of a meta thing i i work on
10:01 : tools myself so i care about these
10:03 : things
10:04 : um okay
10:05 : so yeah we got this failure and now what
10:08 : we want to do is fix it hold on i don't
10:11 : wanna i don't wanna read i wanna fix the
10:14 : bug myself
10:15 : so i'm not going to read the next part
10:18 : um because i wanna
10:21 : that part of the fun of test driven
10:23 : development is
10:24 : you get to change the code and rerun the
10:26 : test
10:27 : and get the passing
10:29 : result
10:30 : and i don't want
10:32 : the
10:33 : fun
10:34 : to be taken away from me so i'm gonna
10:37 : try to fix this myself
10:39 : um
10:42 : i guess what i can do
10:45 : this is too long this code
10:48 : i'm going to take this
10:52 : and extract it into a variable
10:56 : called one day ago
10:59 : and then
11:01 : i think i want a separate one called now
11:08 : so this is now
11:10 : and i can substitute now into here okay
11:14 : so if
11:17 : if
11:18 : if the published date is greater than
11:20 : one day ago then it was published
11:23 : recently
11:24 : however
11:26 : it would not be published recently
11:29 : if published date is greater than now
11:32 : so
11:34 : so the logic should be it was published
11:37 : is greater than one day ago and
11:39 : published date is less
11:44 : or equal to now i think
11:51 : does that seem right
11:53 : published a is less than equal to now
11:57 : then it hasn't been published
11:59 : yet if it's equal to now then it's just
12:03 : published now
12:04 : okay i think this should fix it let's
12:07 : run it rerun the test
12:10 : okay
12:11 : yes that
12:12 : the the test suite is telling me
12:16 : i fixed it
12:21 : so yeah that's more or less what my code
12:24 : did
12:26 : um
12:33 : oh right in python you can actually do
12:36 : this uh
12:38 : do multiple uh multiple
12:42 : comparisons on one line thing
12:45 : so you can
12:47 : that's needle
12:49 : so you can
12:50 : try
12:51 : um
12:53 : uh one
12:55 : day
12:56 : ago i extracted one day ago but they
12:58 : just wrote it long hand
13:01 : and then
13:02 : then you go to self dot pub date and
13:06 : then
13:07 : lesser equal to now so i could write it
13:10 : like this
13:11 : um
13:13 : which would have been equivalent to this
13:16 : long thing with with the n
13:19 : operator combining the two comparisons
13:22 : but they're equivalent internally as
13:25 : they're doing the same thing
13:27 : but uh
13:28 : i will write it with the shorthand
13:32 : and hopefully it still passes and it
13:34 : does cool
13:36 : more comprehensive tests
13:39 : so
13:42 : while we're here we can further pin down
13:44 : the was published recently method in
13:47 : fact it would be positively embarrassing
13:50 : if in fixing one bug we had introduced
13:53 : another so we're going to write
13:56 : a another test
13:59 : let's say
14:00 : that published
14:03 : test
14:04 : was published recently with old question
14:09 : so this time we would make a time that
14:13 : is old so now
14:16 : times on that now
14:18 : minus date time
14:21 : time delta
14:24 : one day
14:26 : and one second ago okay oh seconds
14:32 : and days
14:35 : okay
14:36 : i'm gonna do it like this and then hold
14:39 : question is
14:41 : question with this published date
14:46 : the interchangeability of the date and
14:49 : the time is
14:50 : a little bit
14:53 : weird weirding me out a little bit
14:57 : but i'll deal with it
15:05 : okay so the old one should not be
15:08 : published recently
15:10 : test that
15:12 : okay
15:14 : hold on
15:16 : minus oh i forgot to call this now
15:19 : method
15:20 : and you got confused
15:24 : okay i feel like we need another one
15:28 : another test
15:31 : that will actually return true you know
15:36 : do they do that
15:39 : no they didn't do that i'm gonna do that
15:42 : so
15:43 : if both of these tests
15:46 : test for the false case
15:49 : so
15:50 : which means i could in order to pass
15:52 : this both of them i can just simply
15:54 : return false and that would still pass
15:57 : both of the tests and i think that's not
16:00 : very good so
16:02 : i'm gonna actually write a test that
16:04 : would make the method return true so
16:09 : um
16:11 : maybe it was um
16:14 : it was published five hours ago
16:18 : test
16:19 : was published
16:22 : was actually
16:25 : published
16:27 : recently
16:32 : how do you like that okay so time is
16:34 : going to be time zone that now
16:37 : minus date time that time delta and i'm
16:41 : going to say five hours ago so hours
16:44 : equals five
16:47 : and question is going to be question
16:50 : put
16:51 : date equals time
16:54 : and i'm gonna say self.assert is
16:58 : question
16:59 : that was
17:01 : published
17:03 : recently
17:07 : should be true
17:12 : and it fails
17:16 : because um i kind of returned false
17:20 : on all cases but if i uncommented
17:23 : this code
17:25 : hopefully that will pass now
17:28 : great
17:30 : all right next we're going to test a
17:32 : view
17:34 : um
17:35 : the polls application is fairly
17:39 : undiscriminating it will publish any
17:42 : question
17:43 : including ones whose update field lies
17:46 : in the future we should improve this
17:50 : okay
17:51 : setting up update in the future should
17:53 : mean that the question is published
17:57 : at the moment at that moment but
17:59 : invisible until then
18:02 : a test for a view
18:05 : when we fixed the bug above we wrote the
18:08 : first
18:08 : the test first and then the code to fix
18:11 : it in fact that was an example of test
18:13 : driven development but it doesn't really
18:15 : matter
18:17 : in which order we do the work
18:20 : in our first test we focused
18:22 : closely on the internal behavior of the
18:25 : code
18:27 : for this test we want to check its
18:29 : behavior as it would be experienced by a
18:32 : user through a web browser before we try
18:35 : to fix anything let's have a look
18:37 : at the tools at our disposal
18:41 : the test client
18:45 : okay we can set up the test environment
18:49 : interesting
18:50 : so we're going to go into the shell
18:56 : and
18:57 : i'm going to
18:58 : from django.test.utils
19:01 : i'm going to import set up test
19:04 : environment
19:08 : and then call setup test environment
19:13 : okay
19:14 : this is going to install a template
19:16 : renderer which will allow us to examine
19:19 : some additional attributes
19:21 : on responses such as response.contacts
19:26 : that otherwise would not be available
19:29 : okay this does not set up a data test
19:32 : database so the following will be run
19:34 : against
19:35 : the existing database
19:38 : the output may differ slightly depending
19:40 : on what questions
19:42 : you already created
19:44 : you might get unexpected results if your
19:46 : time zone
19:47 : and settings that pi isn't correct
19:52 : okay
19:54 : um
19:57 : well
19:59 : interesting
20:00 : from django
20:02 : i didn't expect it to
20:05 : show the testing facilities in the show
20:09 : this is an interesting way to do it
20:15 : okay so client we created a client i
20:18 : think our client is like a web browser
20:20 : like you're scripting a web browser
20:23 : client and i'm gonna get i'm gonna call
20:27 : client.get
20:29 : and receive a response from it
20:32 : so we're getting the root url
20:36 : not found
20:38 : no that's what you're supposed to get we
20:41 : should expect a 404 from that address
20:48 : okay
20:50 : i didn't get that
20:54 : response dot status code is 404 that's
20:57 : fine
20:59 : um
21:02 : oh
21:06 : but if i
21:08 : hold on
21:13 : why is the top level
21:16 : not responding oh it is not responding i
21:19 : did i actually didn't expect that
21:22 : i thought the top level actually had
21:24 : something
21:26 : that would respond
21:30 : oh it doesn't okay there isn't a path
21:32 : that matches the empty string
21:36 : for the urls that pi for the top level
21:39 : for the jungle
21:41 : cut
21:43 : okay
21:45 : that's fine so i'm gonna need the
21:47 : reverse method for sort of
21:53 : from django.urls import reverse
21:57 : reverse is does it stand for reverse
22:00 : lookup and fix my spelling of from
22:05 : so if i do response
22:08 : equal to
22:11 : get client.get
22:13 : pulls
22:18 : now i actually get a response
22:21 : that has a status code of 200
22:25 : so that actually hit the view
22:28 : i believe
22:31 : at this index
22:34 : it also has the content here
22:42 : okay
22:43 : i could i could print that
22:48 : or not
22:52 : i thought they would look pretty when i
22:54 : opened it but it doesn't it's in a bite
22:57 : array okay
23:03 : excuse the violin playing in the
23:05 : background
23:06 : or it might it might be good background
23:08 : music so
23:10 : uh all right so we're gonna improve
23:14 : our view apparently
23:17 : um
23:24 : so okay we're gonna make a fix are we
23:27 : gonna write a test first or are we just
23:29 : gonna fix it
23:33 : i think we're gonna fix it first
23:35 : actually
23:39 : let's do that then
23:44 : that's
23:44 : here okay so we're gonna have to import
23:47 : time zone now
24:00 : and then here we're going to add a
24:02 : filter before this order by
24:18 : okay this is weird
24:21 : they're using
24:23 : double underscores
24:27 : so update is less than or equal to
24:31 : timezone.now
24:33 : i'm not a big fan of this syntax but uh
24:37 : that's all right
24:39 : so now
24:41 : we we fixed the code
24:44 : are we gonna write a test now
24:46 : yes we are okay so let's go to the test
24:51 : here and i'm gonna
24:58 : i'm going to write a separate
25:01 : uh
25:02 : function called create question actually
25:06 : okay
25:08 : let's do that
25:13 : and how many days ago it was
25:17 : okay i'm gonna just copy this
25:25 : okay so this is just creating a time
25:29 : uh that is that many days ago and then
25:31 : this is going to create a question that
25:35 : objects that create to create a question
25:38 : with that text and that many days ago
25:41 : and now
25:43 : we're gonna actually write a class that
25:46 : is a test class
26:01 : okay
26:02 : so
26:03 : we might need to import some stuff
26:07 : uh okay we'll figure that out later
26:09 : so we're gonna
26:11 : hit this
26:12 : url
26:15 : or hit this view i should say
26:25 : okay we're hitting the polls index
26:29 : function and
26:32 : okay we're gonna say
26:33 : assert that
26:37 : response status code is 200 and 200
26:42 : means okay
26:44 : in http land
26:55 : so
26:56 : um i guess it's just saying
26:59 : assert that the response object
27:02 : contains this text
27:05 : in it
27:06 : okay
27:10 : you can actually do query set equal
27:14 : that's interesting
27:18 : that suggests to me that
27:23 : the response
27:25 : contains a
27:31 : oh i
27:32 : think i see
27:38 : i see i see i see um
27:41 : response contains a reference to the
27:44 : context that was given to the template
27:47 : render
27:48 : and i actually renamed it to question
27:51 : list
27:52 : so
27:52 : well the tutorial says latest question
27:55 : list
27:56 : i'm going to use question list
27:59 : because i actually changed my template
28:04 : to call
28:06 : this as questionless
28:08 : instead of latest question list
28:11 : so i kind of deviated from the
28:14 : tutorial um
28:16 : okay um and
28:19 : wow there's a a whole bunch of other
28:22 : test cases
28:24 : i actually don't feel like typing them
28:26 : all in
28:28 : um what i'm gonna do is skip that
28:33 : and just run the tests
28:40 : i'm just gonna run the test
28:46 : reverse is not defined
28:56 : reverse where does reverse come from
28:59 : again
29:08 : django urls okay from
29:10 : jungle
29:13 : import reverse
29:20 : a search query set
29:23 : equal
29:32 : that doesn't exist
29:38 : oh query set the set is lowercased
29:45 : okay
29:49 : and that passes okay i kind of want to
29:51 : see it not pass
29:54 : so if i were to break it
30:04 : what is
30:05 : no polls are available
30:14 : why would there be no poles available
30:18 : oh because i filtered them out okay
30:21 : so if i can break it by just returning
30:24 : all questions
30:30 : like that
30:32 : so that should fail
30:37 : it did not fail
30:39 : hold on
30:43 : one two three
30:46 : it did run four tests
30:53 : i thought i had questions
31:27 : i do have two questions so why isn't it
31:30 : rendering them
31:36 : it says no polls are available let me
31:39 : change the text
31:41 : and it should fail in this case at least
31:45 : yes
31:49 : i fixed the text and it passes so
31:54 : this is
31:55 : a little strange
31:58 : i'm not sure why
32:01 : if i misspell this
32:05 : and it should fail
32:07 : yes
32:10 : i'm just returning all the questions
32:12 : here
32:18 : why does it say there are no polls
32:21 : available
32:26 : if questions
32:27 : [Music]
32:52 : i have something here when i run it with
32:54 : my server
32:57 : oh
32:58 : it might be using a test database
33:07 : i think that's what happened
33:10 : because we didn't set up yeah when you
33:13 : run the things under tests
33:15 : it uses a separate database i bet i
33:18 : betcha
33:20 : is there a test database
33:22 : hold on
33:36 : i'm testing is better okay it's saying
33:38 : it's okay to write very
33:42 : redundant tests
33:46 : hold on something should have called
33:48 : create question ah it
33:50 : did we did call create question
33:55 : so okay i think i get it
33:58 : um
34:01 : we have to call create question
34:04 : in order for there to be questions
34:07 : so
34:08 : how's your day
34:12 : that's the question and it was
34:14 : published
34:19 : three days ago
34:21 : so now it should
34:24 : oh no
34:26 : i want to run the test
34:30 : days is not
34:32 : defined line 33
34:37 : days
34:44 : could not find so now it's not true that
34:47 : this passes
34:52 : this makes sense now okay
34:55 : this makes sense to me now
34:58 : i'm gonna put this code back before i
35:01 : forget to
35:02 : um
35:03 : and now
35:05 : i do want to go through the exercise of
35:08 : uh writing all the tests
35:11 : uh
35:12 : that i can explain step by step what
35:14 : each one is doing so let's go so the
35:17 : first test we wrote is just to test that
35:19 : before we create any questions at all
35:23 : um
35:25 : if we go to the index page for the polls
35:28 : there should be it should just say no
35:31 : polls are available
35:33 : i'm gonna
35:34 : make a test the next
35:36 : test to test the case when there are
35:40 : actually some
35:42 : questions
35:43 : in the database already
35:48 : so
35:49 : create a question
36:06 : 30 days ago
36:10 : response
36:12 : self dot client dot get
36:15 : reverse
36:18 : polls
36:22 : and then we're gonna say
36:24 : there should be a question now
36:28 : response.context
36:31 : question
36:32 : list
36:35 : self
36:36 : assert
36:39 : query set equal
36:45 : a list has
36:47 : one question so let me
36:49 : run that
36:52 : okay that passed
36:55 : uh test a future question so this test i
36:59 : wrote basically test if you had a
37:01 : question that was created 30 days in the
37:04 : past
37:05 : we go to
37:08 : the polls index view
37:12 : which is this one
37:14 : it should it should list that
37:17 : in the results
37:19 : here we're going to test a future
37:21 : question and it should not list this
37:23 : future question in the results
37:26 : which is what
37:27 : this filter clause
37:30 : this filter clause that's the one that
37:32 : should have
37:33 : filtered out the future question
37:41 : okay great question
37:46 : question
37:48 : text equals future
37:50 : question
37:53 : days equals 30 days in the future
38:03 : and i'm just going to copy this
38:06 : i'm going to copy both of these actually
38:09 : but
38:10 : the only changes
38:12 : we're going to assert the question list
38:14 : should be empty
38:16 : um one thing i would like to
38:19 : say is that
38:22 : at the beginning of
38:24 : conceptually this is how i understand it
38:27 : uh before each test
38:30 : uh is run
38:32 : for for this view tests test case
38:35 : uh the entire database actually gets
38:38 : cleared out the test database gets
38:41 : destroyed
38:43 : and then
38:44 : recreated it
38:45 : i believe that's what happens
38:48 : therefore you don't have to worry about
38:50 : a another test
38:53 : having created
38:54 : some object there and then that's going
38:56 : to be left over for your test
38:59 : because the whole database gets sort of
39:02 : destroyed and recreated again before
39:05 : every single test case so
39:07 : i can assume it's empty when i create
39:10 : this question and then
39:12 : after i create this question there will
39:13 : only be one question in the database
39:16 : so now i actually want to test this uh
39:20 : code breaking
39:22 : by getting rid of this filter
39:26 : oh that should fail this future question
39:29 : test
39:32 : and it did
39:33 : beautiful and i want to just make sure
39:35 : yeah the test that failed was the future
39:38 : question test i would put in
39:40 : put back the filter
39:42 : code and then it should pass again and
39:45 : uh
39:46 : that's a good practice whenever you're
39:48 : doing something like the
39:50 : retrospectively adding tests
39:53 : to
39:54 : just make sure that some or pre-existing
39:57 : code is already
39:59 : uh
40:00 : working you want to take away that
40:02 : functionality to test the test
40:05 : that's like is this test actually gonna
40:07 : say fail
40:09 : when i take away the functionality that
40:11 : it's testing
40:13 : just a tip there
40:16 : there's a couple more tests
40:25 : okay
40:26 : um i
40:28 : actually don't want to go through all of
40:30 : this um
40:34 : i think it's enough for now
40:38 : uh
40:42 : oh i see the detail
40:44 : the detail view we actually want to put
40:47 : in a filter as well so let's do that i
40:50 : but i'm gonna skip this last two tests
40:53 : it has functionality that's already
40:55 : there um
40:57 : i think if you're if you're new to test
40:59 : driven development uh with django you
41:02 : should definitely
41:05 : get some more practice type type them in
41:07 : and see that they pass but i'm actually
41:09 : going to skip to the detail view
41:12 : so
41:13 : this is saying
41:15 : i'm going to put in the filter for the
41:16 : detail view as well
41:19 : over here uh but what i'm going to do is
41:22 : write the test first i'm going to switch
41:24 : to the tdd
41:26 : i mean the test first methodology okay
41:29 : so i'm going to write a
41:32 : question detail
41:34 : view tests
41:40 : remember earlier they said you can write
41:42 : the test first or write them after it
41:45 : doesn't matter the order
41:46 : um
41:49 : i'm going to switch back to the writing
41:51 : the test first
41:54 : okay
41:55 : so if we get a future question in a
41:58 : detail view
41:59 : it should say 404 not found is what this
42:02 : is saying so future question
42:24 : let's do it like this
42:28 : okay and then i'm gonna have a url
42:32 : okay i see
42:45 : okay that's the url and we're going to
42:47 : fetch it
42:49 : response cosel client.get url
42:54 : okay so this reverse function call just
42:57 : build a url with this argument
43:01 : now i'm going to feed the url to
43:03 : client.get
43:09 : i'm going to say the response code
43:11 : status code
43:13 : should equal to
43:16 : 404
43:18 : um
43:19 : let's run this
43:22 : that should fail because we haven't done
43:24 : the filtering and it's giving a 200
43:28 : so
43:29 : let's go ahead and do the filtering now
43:32 : which is done like get query set
43:38 : like this
43:39 : um the code is over here
43:42 : so we're gonna return question
43:46 : objects dot filter
43:48 : pub
43:52 : update less than or equal to times um
43:58 : that now
44:00 : and now it should pass
44:03 : yep uh let's write that second test
44:06 : for a past
44:08 : question
44:21 : so if we have a past question
44:29 : um
44:31 : it's text is past question
44:34 : okay and then days is negative five
44:40 : five days ago
44:41 : and url is reverse
44:44 : pulse
44:46 : detail
44:47 : and then there's some arcs
44:50 : past
44:52 : question.id comma
44:56 : again this trailing comma makes this
44:59 : expression a tuple which is actually
45:02 : important in this case
45:08 : so the search contains
45:11 : response
45:13 : past
45:14 : question
45:15 : question
45:16 : text okay let's see
45:20 : so these should all pass okay
45:23 : um
45:24 : ideas for more tests i might do one
45:28 : um
45:29 : so we ought to add similar get query
45:32 : set method to result view and create a
45:35 : new
45:36 : test class
45:37 : for that view
45:40 : there will be a lot of repetition we
45:42 : could improve our application in other
45:44 : ways adding tests along the way for
45:46 : example it's silly that questions can be
45:49 : published on the site that have no
45:51 : choices
45:52 : so our views could check for this
45:54 : and exclude
45:57 : such questions
46:00 : interesting
46:03 : our tests could create a question
46:06 : without choices
46:07 : and that
46:08 : tests that it's not published
46:12 : um maybe let me think
46:17 : okay
46:19 : as well as create a similar question
46:22 : with choices let's do this one
46:24 : so it's saying
46:26 : if i if i um
46:30 : let's see i could actually add this to
46:33 : the model test
46:35 : and
46:36 : it's basically saying if this question
46:39 : doesn't have
46:41 : choices in it
46:44 : it should not be considered
46:46 : published
46:52 : so maybe we add that to
46:58 : maybe what we do is we add that to this
47:02 : method to check does it have any choices
47:07 : um
47:08 : we could add a model test to track that
47:12 : and that would be a very easy model test
47:14 : to write we could also write a view test
47:17 : to double verify that
47:19 : is the case
47:21 : um
47:24 : i'm gonna do
47:26 : maybe both i'm gonna do this one first
47:28 : so
47:30 : test a test
47:32 : uh question
47:34 : has no
47:37 : choices
47:40 : uh but the problem is uh in that's gonna
47:44 : screw up the results of these first
47:46 : three
47:48 : questions we will actually need to
47:54 : add choices
47:56 : to these first three
47:58 : once we add this
48:00 : restriction
48:02 : so i think what we will need to do is
48:04 : say
48:09 : so basically if we
48:11 : um
48:16 : so this would
48:18 : fail now basically
48:21 : this
48:22 : should fail because this question
48:24 : doesn't have choices
48:27 : um what i'm gonna do is comment out
48:30 : these
48:31 : previous ones
48:33 : this is a thing that i do
48:35 : um
48:36 : i'm gonna
48:37 : have this test
48:39 : just focus on this one test because i
48:41 : know i'm gonna break the other three
48:45 : so
48:46 : if the question has no choices um it
48:50 : was published recently should be false
48:53 : we should consider it
48:55 : not yet published and we run this test
48:58 : it should
48:59 : fail right now
49:02 : and now to uh to pass it what we're
49:05 : gonna need to do
49:08 : is change this logic
49:10 : um
49:14 : and
49:17 : has choices
49:19 : how do i tell if it has choices or not
49:22 : um i think i can say so that choice set
49:26 : probably
49:28 : um
49:30 : what does a choice set
49:33 : have
49:35 : uh
49:37 : maybe like i can probably just do a
49:40 : length
49:41 : of the choice
49:43 : dot dot all maybe
49:47 : does that work
49:50 : zero is not false
49:55 : oh
49:56 : his true length is
49:59 : greater than zero
50:02 : i think i did it okay
50:04 : um
50:05 : i did it
50:07 : but now
50:09 : i'm gonna
50:10 : change this one that says it was
50:12 : actually published recently and i'll
50:14 : have to add some choices to the choice
50:16 : set no just one is enough
50:20 : um
50:21 : i think you say create
50:24 : and how do you create a choice
50:29 : um and i'm just doing it by memory but i
50:32 : think
50:34 : how to create
50:35 : something
50:36 : via the choice set was covered in
50:43 : part two or something
50:46 : where's the index
50:51 : going back to the table of contents
50:55 : i'm gonna go to part two i think
51:02 : uh
51:03 : playing with the api that's where
51:06 : they showed how to do this i believe
51:09 : they had choice set
51:13 : yeah choice set create
51:16 : there it is okay so you can find it
51:18 : there um
51:20 : i'm sure you can find it in the docs as
51:22 : well so
51:24 : choice set create and i can put in the
51:27 : choice
51:29 : text
51:30 : equals to
51:33 : i'll just write choice one
51:37 : votes
51:38 : i'll put in zero
51:41 : and so as long as there's at least one
51:44 : choice in the choice set
51:47 : that should
51:48 : return actually i want to see that
51:54 : go
51:55 : fail first
51:56 : yep that fails
51:58 : i put it in
52:00 : and now i want to see it pass
52:03 : no
52:04 : what happened
52:10 : safe prohibited
52:13 : to prevent data loss
52:16 : to the unsafe related object question oh
52:19 : i i'm gonna have to save this question
52:23 : is that what it is
52:29 : no
52:40 : unsaved related object or should i save
52:45 : the question first before creating the
52:47 : choice set maybe that's what it is
52:51 : yes
52:52 : i see i have to save the parent
52:55 : before i create the choice
52:59 : that associates
53:00 : to the question so that works
53:03 : and i think i can
53:05 : uncomment these other two but i'm gonna
53:08 : have to do the same thing
53:10 : to the other two
53:12 : except the
53:13 : variable is called old question here
53:17 : and here is called future question
53:24 : so let's see if i can get all of those
53:27 : tests to pass and yes
53:31 : managed that
53:34 : now
53:40 : now i think
53:43 : i want to also write a view test
53:47 : um that says
53:50 : if the question doesn't have any um
53:58 : any choices
54:01 : therefore it was not published
54:04 : and therefore
54:06 : it should also not get listed
54:17 : i'm a little surprised that it's
54:21 : not working currently
54:24 : because with the past question
54:28 : if i create a past question
54:32 : and it has no choices
54:34 : and shouldn't
54:37 : have any choices because i didn't create
54:39 : them
54:41 : i didn't create choices in here
54:44 : why is it that this is still listing it
54:55 : oh i see this filter doesn't
55:00 : check
55:03 : it
55:04 : doesn't check for the was was published
55:07 : recently flag
55:09 : oh
55:11 : okay i messed it up actually
55:14 : um
55:22 : maybe i should not have done all of that
55:25 : uh okay
55:29 : i'm gonna revert of what i did
55:32 : i feel like is this logic correct um who
55:37 : is it published
55:50 : this logic is actually correct
55:53 : as in it wasn't published recently if it
55:57 : doesn't have
55:59 : choices so it must have choices in order
56:03 : to be considered published recently but
56:05 : this method actually has no bearing
56:08 : on the filters that are used
56:11 : for these views and that's what i missed
56:14 : so it's kind of like
56:17 : i did some wasted work here
56:20 : i think i'm gonna revert what i just did
56:23 : i'm just gonna revert all of it
56:29 : sometimes i know this can feel painful
56:31 : but i feel like that's the right thing
56:33 : to do because
56:35 : um
56:36 : if you don't need
56:37 : to write something
56:40 : you shouldn't write it
56:42 : if if
56:44 : you know
56:46 : if it's if the code
56:48 : written
56:50 : isn't required
56:52 : for the real requirement
56:55 : then it should not be written at all so
56:58 : i'm gonna undo
57:00 : undo this uh
57:05 : this functionality
57:08 : i'm gonna retest it make sure it's still
57:11 : in the passing state and i'm actually
57:13 : going to now
57:16 : write a um
57:18 : try to pass the other functionality i
57:21 : was going for which is
57:23 : um i want the to write a view test
57:28 : and i only want to
57:34 : show
57:35 : questions that actually
57:38 : have
57:39 : i only want to consider
57:41 : published
57:42 : those questions that
57:44 : uh
57:50 : those questions
57:52 : that have choices in them
57:56 : um this begs a question we might want to
57:59 : use a uh
58:01 : use a method to encapsulate that logic
58:05 : um but i might need to do a little bit
58:07 : of research as to how to do that
58:11 : actually and seeing that
58:13 : this video has gone
58:15 : on
58:16 : a bit i might separate it
58:18 : into a different video
58:21 : so i
58:23 : am going to stop that here and i will
58:25 : see you in the next one